Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sh and zsh, add Linux's pwsh, always quote default shell #68

Merged
merged 6 commits into from
Apr 16, 2024
Merged

add sh and zsh, add Linux's pwsh, always quote default shell #68

merged 6 commits into from
Apr 16, 2024

Conversation

xgqt
Copy link
Contributor

@xgqt xgqt commented Apr 14, 2024

This PR introduces a breaking change to always quote Command passed to a custom shell.
Comments and discussion welcome.

xgqt added 3 commits April 14, 2024 15:22
@xgqt
feat(shell): add standard sh and zsh support
73f1f9f 
Signed-off-by: Maciej Barć <[email protected]>
@xgqt
feat(command): reverse quoteBashCommand check
9d8257c 
now non-NT (SH, BASH, ZSH) and custom shells will default to quoting
the Command, see modified tests for a reference

Signed-off-by: Maciej Barć <[email protected]>
@xgqt
feat(command): support pwsh on Linux too
bae70d2 
Signed-off-by: Maciej Barć <[email protected]>
@CaptnCodr
Copy link
Owner

Hey @xgqt,
thank you for your PR.

Could you:

  • Add a test for non-windows systems in ShellCommandExecuteTests.fs for SH
    • ZSH is native on macos, isn't it? => Then add a test for it.
  • Add SH & ZSH to the provided Fli.Shells in the README.md

Thank you 🙂

@xgqt
Copy link
Contributor Author

xgqt commented Apr 15, 2024

  • Add a test for non-windows systems in ShellCommandExecuteTests.fs for SH
    • ZSH is native on macos, isn't it? => Then add a test for it.

Sure but I will have to "blindly" add Macos stuff as I do not have any Apple gear.

  • Add SH & ZSH to the provided Fli.Shells in the README.md

Yup.

@xgqt xgqt force-pushed the 2024-xgqt-feature-shells branch from 8f9f230 to 019ddaa Compare April 15, 2024 16:57
@xgqt
Copy link
Contributor Author

xgqt commented Apr 15, 2024

had to also update a PWSH->string test case for Linux

@CaptnCodr
Copy link
Owner

That looks good. 🙂
Appreciate your work. I will create a release later this day.

If you want you could develop that feature with stdout/stderr as output (#63)?

@CaptnCodr CaptnCodr merged commit 4bc9985 into CaptnCodr:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgqt @CaptnCodr